refactor(skipLast): fix names, update docs and comments#5788
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Mar 15, 2021
Merged
Conversation
Member
|
Hi @benlesh, thank you a lot for this PR and for taking care of it. I will gladly take a look at this PR. |
Member
jakovljevic-mladen
left a comment
jakovljevic-mladen
left a comment
There was a problem hiding this comment.
LGMT. 2 small nitpicks and an error in an example. I think that you solved the issue that I tried much better than I have. And updating docs and adding comments is also 👍
Collaborator
|
@benlesh Is this ready to be reviewed? |
- Fixes names to be a little more relevant. - Adds additional comments to the code about why it is doing what it is doing - Updates documentation - Remove incorrect documentation about thrown values
cartant
force-pushed
the
refactor/skipLast-fix-names-update-docs
branch
from
d891bc6 to
6cd4691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by @jakovljevic-mladen's PR: #5784